[sr-dev] git:master: modules_k/presence Fixed DB Storage Modes

[Peter Dunkley]

Hi,

I just tried this updated presence module and ran into some problems.

The scenario I use is presence and RLS.  The client SUBSCRIBEs to a
single resource list on the RLS and to presence.winfo on the PS.  The
client PUBLISHes to the PS.

With the new code I get two error messages out a lot:

        Feb 29 11:31:18 pd-laptop-linux ./kamailio[22566]: ERROR:
        presence [subscribe.c:799]: wrong status
        Feb 29 11:32:39 pd-laptop-linux ./kamailio[22566]: ERROR:
        presence [subscribe.c:1314]: wrong sequence number received: 4 -
        stored: 10


I also get segmentation faults when I change presence state or log out.
Here is a fragment of the back-trace:

        #0  0x00007f0447191438 in get_subs_db (pres_uri=0x7fff0ce09ea0,
        event=0x7f0443f15728, sender=<optimized out>,
        s_array=0x7fff0ce09bf0, n=0x7fff0ce09c00) at notify.c:1120
        #1  0x00007f044719375f in get_subs_dialog
        (pres_uri=0x7fff0ce09ea0, event=0x7f0443f15728, sender=0x0) at
        notify.c:1238
        #2  0x00007f04471994ce in query_db_notify
        (pres_uri=0x7fff0ce09ea0, event=0x7f0443f15728,
        watcher_subs=0x0) at notify.c:1353
        #3  0x00007f04471b024e in update_subscription
        (msg=0x7f044d36ec38, subs=0x7fff0ce09ea0, to_tag_gen=<optimized
        out>, sent_reply=0x7fff0ce09ff0) at subscribe.c:452
        #4  0x00007f04471be82a in handle_subscribe (msg=0x7f044d36ec38,
        str1=<optimized out>, str2=<optimized out>) at subscribe.c:805
        #5  0x00000000004e50c5 in do_action (h=0x7fff0ce0c950,
        a=<optimized out>, msg=0x7f044d36ec38) at action.c:1116

I rolled back to the previous version of presence and it all works
correctly as before.

Thanks,

Peter

On Wed, 2012-02-15 at 13:45 +0100, Anca Vamanu wrote:

> Module: sip-router
> Branch: master
> Commit: ae86ca3611398ce365ac4a1776ff0c7e95476bbe
> URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ae86ca3611398ce365ac4a1776ff0c7e95476bbe
> 
> Author: Anca Vamanu <anca.vamanu at 1and1.ro>
> Committer: Anca Vamanu <anca.vamanu at 1and1.ro>
> Date:   Wed Feb 15 13:39:55 2012 +0200
> 
> modules_k/presence Fixed DB Storage Modes
> 
> - removed db_mode and fallback2db parameters and added two new
>   parameters: subs_db_mode and publ_cache
> - fixed and extended the storage modes for subscriptions: Memory Only,
>   Write Through, Write Back, DB Only
> - publ_cache parameter offers the possibility to disable publish cache
> - some other fixes:
>     - delete subscription only for 481 or 408 reply for Notify
>     - call child_init also for main process (no shutdown DB flush was
>       being performed)
> 
> ---
> 
>  modules_k/presence/README                 |  190 ++++++-----
>  modules_k/presence/bind_presence.c        |    4 +-
>  modules_k/presence/bind_presence.h        |    4 +-
>  modules_k/presence/doc/presence_admin.xml |  127 +++++---
>  modules_k/presence/doc/presence_devel.xml |    2 +-
>  modules_k/presence/event_list.c           |    2 +-
>  modules_k/presence/event_list.h           |    2 +-
>  modules_k/presence/hash.c                 |   25 +--
>  modules_k/presence/hash.h                 |    2 +-
>  modules_k/presence/notify.c               |  253 ++++++---------
>  modules_k/presence/notify.h               |    2 +-
>  modules_k/presence/presence.c             |  108 +++----
>  modules_k/presence/presence.h             |   19 +-
>  modules_k/presence/presentity.c           |   30 +--
>  modules_k/presence/presentity.h           |    2 +-
>  modules_k/presence/publish.c              |   52 ++--
>  modules_k/presence/publish.h              |    2 +-
>  modules_k/presence/subscribe.c            |  495 +++++++++++++++++++----------
>  modules_k/presence/subscribe.h            |    7 +-
>  modules_k/presence/utils_func.c           |    2 +-
>  modules_k/presence/utils_func.h           |    2 +-
>  modules_k/pua/hash.h                      |    1 +
>  22 files changed, 736 insertions(+), 597 deletions(-)
> 
> Diff:   http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=ae86ca3611398ce365ac4a1776ff0c7e95476bbe
> 
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


-- 
Peter Dunkley
Technical Director
Crocodile RCS Ltd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20120229/03fa54bd/attachment.htm>