[sr-dev] couple of xavp questions

[Olle E. Johansson]

12 dec 2012 kl. 10:28 skrev Daniel-Constantin Mierla <miconda at gmail.com>:

> Hello,
> 
> On 12/9/12 11:47 AM, Olle E. Johansson wrote:
>> 9 dec 2012 kl. 11:09 skrev Andreas Granig <agranig at sipwise.com>:
>> 
>>> Hi,
>>> 
>>> On 12/09/2012 10:54 AM, jh at tutpro.com wrote:
>>>> Olle E. Johansson writes:
>>>> 
>>>>> In addition: Xavps are not as well documented as avps. We need to add
>>>>> something. There's a wiki page with a proposal from Daniel, but I
>>>>> don't know if it documents the way it turned out in the code.
>>>> yes, looks like currently both xavp api doc and xavp pseudo var descriptions
>>>> are missing.
>>> I tried to dig into the config syntax some weeks ago, but found it quite
>>> confusing:
>>> http://www.mail-archive.com/sr-users@lists.sip-router.org/msg11242.html
> guess I missed this message, I will look it up and reply.
> 
>>> 
>>> The potential is great, but imho it needs some tweaking to be really
>>> consistent and useful.
>> OK, so let's reveal the magic of this powerful stuff and document it.
>> 
>> The document I found is here:
>> http://sip-router.org/wiki/devel/xavp
>> 
>> I can't judge if this is ideas/brainstorm or actual documentation of the implementation that we have.
> Yes, the document was published based on implementation, to see if there are suggestions for improvement. Nothing radical was changed, so it is quite actual.
Ok, so we can edit away the "proposal" word ;-)

> 
>> 
>> Xavps are implemented in /xavp.c so it's not a module. We need a wiki page documenting
>> it.
>> 
>> * http://devel.kamailio.org/doxygen/ seems outdated.
> 
> Henning was running that server, maybe something got broken in auto-generation of the doxygen.
Henning?

> 
>> * http://sip-router.org/doxygen/sip-router/branch/master/files.html also is not up to date.
> 
> I guess Jan or other ser folk made it in the past, probably not a service updated periodically.
> 
>> 
>> Looking into the source code files (xavp.[ch], the percentage of comments for doxygen and other developers is very low.
> I will add comments there. For a period of time the xavps were not popular, but it is good that they are taking off.
> 
>> 
>> Anyone else that have found any source of documentation?
> 
> C code, always :-)
Of course!


/O