[sr-dev] git:master: core and several modules: instance and reg_id in branch_t
Daniel-Constantin Mierla
miconda at gmail.com
Sat Dec 8 13:47:24 CET 2012
On 12/8/12 1:36 PM, Juha Heinanen wrote:
> Daniel-Constantin Mierla writes:
>
>> you patch changes the values for server and user-agent value in
>> config.h.
> sorry, that was my mistake. i'll fix it.
>
>> Could be better to split such large commits (when there are internal api
>> changes) on affected components, because it is easier to look at the
>> patches (e.g., doing one commit for each affected module and one for the
>> core) -- not a rule, just an observation based on past experiences.
> if i had spit it, people would have complained that master is not
> compiling. i would not have likes someone to do that to me.
You can commit locally and push all at once, so practically all of them
will be available on remote repository at the same time. I did it many
times (it is actually the usual way because it easier to review later or
send only specific links to the authors of the components I want to be
reviewed).
Cheers,
Daniel
--
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
More information about the sr-dev
mailing list