[sr-dev] git:master: core: Added void to declarations of functions with empty argument list

[Marius Zbihlei]

Module: sip-router
Branch: master
Commit: abb01fb41068f9accc49f638b107abc12d83ef5e
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=abb01fb41068f9accc49f638b107abc12d83ef5e

Author: Marius Zbihlei <marius.zbihlei at 1and1.ro>
Committer: Marius Zbihlei <marius.zbihlei at 1and1.ro>
Date:   Mon Apr  2 17:19:17 2012 +0300

core: Added void  to declarations of functions with empty argument list

In C language, a declaration in the form int f(); is equivalent to int f(...);, thus being able to accept an indefinit number of parameters. With the -Wstrict-prototypes GCC options, these declarations are reported as "function declaration isn’t a prototype".
On some cases, this may trick the compiler into generating unoptimized code (like preparing to handle variadic argument list).
In all cases having a declaration int f() and a definition inf f(int) is missleading, even if standard compliant.
This is still Work in Progress. (maybe adding the -Wstrict-prototypes option to default is desireable)

---

 atomic_ops_init.h |    4 ++--
 basex.h           |    2 +-
 cfg/cfg_select.h  |    4 ++--
 counters.h        |    4 ++--
 daemonize.c       |    2 +-
 daemonize.h       |   12 ++++++------
 dns_cache.h       |    4 ++--
 dprint.h          |    2 +-
 dst_blacklist.c   |    2 +-
 dst_blacklist.h   |    4 ++--
 endianness.h      |    2 +-
 flags.h           |    2 +-
 hash_func.c       |    2 +-
 lock_ops.c        |    4 ++--
 lock_ops_init.h   |    4 ++--
 main.c            |   14 +++++++-------
 nonsip_hooks.h    |    4 ++--
 poll_types.h      |    2 +-
 pt.h              |    6 +++---
 rand/fastrand.h   |    2 +-
 resolve.h         |    2 +-
 route.h           |    8 ++++----
 rpc_lookup.h      |    4 ++--
 script_cb.h       |    4 ++--
 sctp_options.h    |    6 +++---
 sctp_server.h     |   12 ++++++------
 select_buf.h      |    2 +-
 shm_init.h        |    4 ++--
 socket_info.h     |   10 +++++-----
 tcp_init.h        |    8 ++++----
 tcp_options.h     |    6 +++---
 tcp_stats.h       |    4 ++--
 timer.h           |   18 +++++++++---------
 tls_hooks.h       |    4 ++--
 tls_hooks_init.h  |    8 ++++----
 udp_server.h      |    2 +-
 ut.h              |    2 +-
 37 files changed, 93 insertions(+), 93 deletions(-)

Diff:   http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=abb01fb41068f9accc49f638b107abc12d83ef5e