[sr-dev] [tracker] Task opened: wrong integer parameters parsing in ndb_redis

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened.  Details are below. 

User who did this - Andrew Pogrebennyk (marduk) 

Attached to Project - sip-router
Summary - wrong integer parameters parsing in ndb_redis
Task Type - Bug Report
Category - Core
Status - Assigned
Assigned To - Andrei Pelinescu-Onciul
Operating System - All
Severity - Low
Priority - Normal
Reported Version - Development
Due in Version - Undecided
Due Date - Undecided
Details - There appears to be a problem with integer parameters parsing in ndb_redis (cannot override default db and port). Please review and accept the patch:

diff --git a/modules/ndb_redis/redis_client.c b/modules/ndb_redis/redis_client.c
index 6a91019..9f4ffc4 100644
--- a/modules/ndb_redis/redis_client.c
+++ b/modules/ndb_redis/redis_client.c
@@ -71,10 +71,10 @@ int redisc_init(void)
                                addr = pit->body.s;
                                addr[pit->body.len] = '\0';
                        } else if(pit->name.len==4 && strncmp(pit->name.s, "port", 4)==0) {
-                               if(!str2int(&pit->body, &port))
+                               if(str2int(&pit->body, &port) < 0)
                                        port = 6379;
                        } else if(pit->name.len==2 && strncmp(pit->name.s, "db", 2)==0) {
-                               if(!str2int(&pit->body, &db))
+                               if(str2int(&pit->body, &db) < 0)
                                        db = 0;
                        }
                }


More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=162

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.