[sr-dev] [tracker] Task opened: add a couple of missing free_to_params (mem leaks) (Attachment added)

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened.  Details are below. 

User who did this - Walter Doekes (wdoekes) 

Attached to Project - sip-router
Summary - add a couple of missing free_to_params (mem leaks)
Task Type - Bug Report
Category - Module
Status - Unconfirmed
Assigned To - 
Operating System - All
Severity - Medium
Priority - Normal
Reported Version - Development
Due in Version - Undecided
Due Date - Undecided
Details - Hi,

as a complement to FS#155, I've added a couple of more explicit free_to_params that were missing and are causing memory leaks. (At least they are leaking on opensips, they should be leaking here as well. See also https://sourceforge.net/tracker/?func=detail&aid=3411483&group_id=232389&atid=1086410 )

I touched the following files:

modules_k/presence/subscribe.c
modules_k/pua/hash.c
modules_k/pua/send_subscribe.c
modules_k/pua_bla/notify.c
modules_k/pua_xmpp/simple2xmpp.c
modules_k/pv/pv_trans.c
modules_k/rls/resource_notify.c

While adding free_to_params, I replaced the memset(0) with a static 0 initialization, to at least get param_lst as 0 in case parse_to() wasn't touched. (Same with the early memset in modules_k/pv/pv_trans.c.)

While I was in the neighbourhood, I also removed an unused 'doc' variable from modules_k/pua_bla/notify.c and modules_k/pua_xmpp/simple2xmpp.c.

And I added a couple of pkg_free(uri)'s to modules_k/pua_xmpp/simple2xmpp.c.

Regards,
Walter Doekes
OSSO B.V.

One or more files have been attached.

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=156

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.