[sr-dev] Via parser does not accept any token as transport

Iñaki Baz Castillo ibc at aliax.net
Tue Sep 13 22:10:12 CEST 2011


2011/9/13 Daniel-Constantin Mierla <miconda at gmail.com>:
> you started the discussion when many of us were partying for 10 years
> celebration :-) so it got lost -- reminders are recommended always.
>
> There is no real good reason why not accepting unknown transport protocols
> non-top Vias. The limitation is coming from implementation of the parser,
> but should be relaxed.
>
> The best would be to introduce PROTO_OTHER in the enum of protocols
> (ip_addr.h, enum sip_protos) and in case this type is encountered, read the
> string value of the protocol.
>
> Via parser is using quite a lot of states, so if you look to update it, when
> it gets to the state where the transport (proto) part starts, if does not
> match UDP, TCP, TLS or SCTP, then set vb->proto=PROTO_OTHER and start and
> length of the token in vb->transport. Should not be very complex to enhance
> once you get into via parser states.
>
> I may fix it before 3.2.0 is out if you are not doing it meanwhile, but
> cannot give you a timeline for it right now.


Thanks a lot Daniel !

I will try to do it by myself by following your useful indications. If
I get it I will announce prior to commiting it.

Thanks.


-- 
Iñaki Baz Castillo
<ibc at aliax.net>



More information about the sr-dev mailing list