[sr-dev] Freeze rules and undoing a needless string copy

Alex Hermann alex at speakup.nl
Thu Sep 8 18:25:59 CEST 2011


Hello,

i'm not aware of the exact rules regarding the bug-fixing freeze of the master 
branch, hence this question.

I accidentally introduced a needless string copy in sql_xquery(), 
sql_pvquery() and auth_db's load_credentials because i was unaware of the fact 
that pv_setf_t () already  requires implementations to implement a string copy 
of their own.

As this is not strrictly a bug (everything works well but just a little less 
efficient), would removing this needles copy violate the 'freeze' rules, or 
can i consider it a bug fix?

The patch i'm proposing to commit is attached.

-- 
Alex Hermann
-------------- next part --------------
A non-text attachment was scrubbed...
Name: eliminate-string-copy.diff
Type: text/x-patch
Size: 3071 bytes
Desc: not available
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20110908/f1c8b3c4/attachment-0001.bin>


More information about the sr-dev mailing list