[sr-dev] [tracker] Comment added: Not available AVP's values in reply route when pua_dialoginfo.so is added to config

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#150 - Not available AVP's values in reply route when pua_dialoginfo.so is added to config
User who did this - Sebastian Zaprzalski (-sz-)

----------
Jasmin, you are right. Some time ago I've tryed a patch:

diff -ur x/kamailio-3.1.4/modules/tm/h_table.c kamailio-3.1.4/modules/tm/h_table.c
--- x/kamailio-3.1.4/modules/tm/h_table.c	2011-05-26 18:08:02.000000000 +0000
+++ kamailio-3.1.4/modules/tm/h_table.c	2011-08-11 10:19:05.317094450 +0000
@@ -330,22 +330,38 @@
 	old = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, 
 			&new_cell->uri_avps_from );
 	new_cell->uri_avps_from = *old;
-	*old = 0;
+	if (p_msg) {
+		*old = 0;
+	} else { 
+		new_cell->uri_avps_from = NULL;
+	}
 
 	old = set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, 
 			&new_cell->uri_avps_to );
 	new_cell->uri_avps_to = *old;
-	*old = 0;
+	if (p_msg) {
+		*old = 0;
+	} else { 
+		new_cell->uri_avps_to = NULL;
+	}
 
 	old = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, 
 			&new_cell->user_avps_from );
 	new_cell->user_avps_from = *old;
-	*old = 0;
+	if (p_msg) {
+		*old = 0;
+	} else { 
+		new_cell->user_avps_from = NULL;
+	}
 
 	old = set_avp_list(AVP_TRACK_TO | AVP_CLASS_USER, 
 			&new_cell->user_avps_to );
 	new_cell->user_avps_to = *old;
-	*old = 0;
+	if (p_msg) {
+		*old = 0;
+	} else { 
+		new_cell->user_avps_to = NULL;
+	}
 
 #ifdef WITH_XAVP
 	xold = xavp_set_list(&new_cell->xavps_list );
diff -ur x/kamailio-3.1.4/modules/tm/uac.c kamailio-3.1.4/modules/tm/uac.c
--- x/kamailio-3.1.4/modules/tm/uac.c	2011-05-26 18:08:02.000000000 +0000
+++ kamailio-3.1.4/modules/tm/uac.c	2011-08-11 10:19:05.317094450 +0000
@@ -375,19 +375,6 @@
 				/* restore original environment */
 				setsflagsval(sflag_bk);
 
-				if (unlikely(lreq.new_uri.s))
-				{
-					pkg_free(lreq.new_uri.s);
-					lreq.new_uri.s=0;
-					lreq.new_uri.len=0;
-				}
-				if (unlikely(lreq.dst_uri.s))
-				{
-					pkg_free(lreq.dst_uri.s);
-					lreq.dst_uri.s=0;
-					lreq.dst_uri.len=0;
-				}
-
 				if (unlikely(lreq.add_rm || lreq.body_lumps)) {
 					LM_DBG("apply new updates to sip msg\n");
 					buf1 = build_req_buf_from_sip_req(&lreq,


but there are some problems with memory. 

----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=150#comment266

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.