[sr-dev] git:master: modules_k/nathelper: add_contact_alias adds <> s around contact URI

Alex Hermann alex at speakup.nl
Wed Sep 7 11:15:25 CEST 2011


On Wednesday 07 September 2011, Juha Heinanen wrote:
> i reviewed your patch and it looked ok to me except i added one line to
> initialize lt and param variebles:
> 
>     /* Check if Contact URI needs to be enclosed in <>s */
>     lt = param = NULL;

Thanks, that disappeared from the original code by accident.

> i also tested the case when brackets exist already in incoming request
> and it worked ok as before.  so far i have not had opportunity to test
> the case where brackets are missing in incoming request.

I'm still wondering whether you have a case where the original code is 
working for a Contact without brackets.

-- 
Alex Hermann




More information about the sr-dev mailing list