[sr-dev] git:master: modules_k/nathelper: add_contact_alias adds <> s around contact URI

[Alex Hermann]

On Tuesday 06 September 2011, you wrote:
> Alex Hermann writes:
> > this commit seems to suffer from an off-by-one bug, placing the alias
> > parameter outside the just added <>. Attached commit should fix this.
> > If you agree, i'll commit is asap.
> 
> i was able to make one test and didn't see any problems:
> 
> incoming contact:
> 
> Contact: <sip:jh_test_fi at 192.98.102.10:5074;transport=tcp>

The problem is with contacts that have no <> surrounding them, which is the 
situation your patch was handling.

Contact: sip:192.168.1.10:5678

became

Contact: <sip:192.168.1.10:5678>;alias=123.123.123.123~1234~18

alias has become a header parameter instead of of a uri parameter. In my 
patch i try to fix it and the result is now:

Contact: <sip:192.168.1.10:5678;alias=123.123.123.123~1234~18>


-- 
Alex Hermann