[sr-dev] [tracker] Task opened: tm lw_parser skips 4 bytes past Call-ID: (Attachment added)

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened.  Details are below. 

User who did this - Walter Doekes (wdoekes) 

Attached to Project - sip-router
Summary - tm lw_parser skips 4 bytes past Call-ID:
Task Type - Bug Report
Category - tm
Status - Assigned
Assigned To - Andrei Pelinescu-Onciul
Operating System - All
Severity - Very Low
Priority - Normal
Reported Version - Development
Due in Version - Undecided
Due Date - Undecided
Details - Hi,

while looking for something else, I stumbled on a very very minor issue:


build_local_reparse()
....
/* parse HF name */
s = lw_get_hf_name(s, invite_buf_end, &hf_type);

When hf_type == HDR_CALLID_T then s points 4 bytes past the ':'.

So, when we have buffer = "Call-ID: abc...", 
then s is not ": abc..."
but s is "c...".

This is because p gets incremented by 4 and later by 7, instead of 4+3.


This issue is completely harmless, because build_local_reparse seeks to EOL (s = lw_next_line(s, invite_buf_end)) and uses the entire line.
(This would only cause funny behaviour if you have a very short -- one octet -- Call-ID.)


See patch.

Regards,
Walter Doekes
OSSO B.V.


One or more files have been attached.

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=168

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.