[sr-dev] modules_k/dialog: no referencing to current dialog possible when using dlg_manage()

Timo Reimann timo.reimann at 1und1.de
Mon Mar 7 11:40:39 CET 2011


Hey Daniel,


On 07.03.2011 11:01, Daniel-Constantin Mierla wrote:
> all looks safe, if you or anyone else had a chance to give it a try,
> then you can backport.

Did several tests, all looking well; back-ported the commit.

@侯旭光: Can you also give it a try using the latest git version of
either master, 3.1, or 3.0?


Cheers,

--Timo



> On 3/7/11 10:17 AM, Timo Reimann wrote:
>> Hey,
>>
>>
>> On 04.03.2011 21:21, Daniel-Constantin Mierla wrote:
>>>> So how do we fix this?
>>>>
>>>> My idea is to simply remove the not-NULL-check against the transaction t
>>>> prior to callback registration. If the transaction doesn't exists, the
>>>> tm module makes sure that it will be created lazily. This is how the
>>>> first callback registration for types TMCB_RESPONSE_READY and
>>>> TMCB_RESPONSE_FWDED in dlg_create_dialog() already works, apparently
>>>> with no issues. I also did a quick, simple test with the check left out
>>>> that proved to work fine.
>>>>
>>>> As this looks like a fix to a work-around, however, I'd like to ask for
>>>> some feedback first.
>>> go ahead and commit it on master. I will look over it as well and then
>>> we can backport.
>> Done committing to master.
>>
>>
>> Cheers,
>>
>> --Timo
> 
> --
> Daniel-Constantin Mierla
> http://www.asipto.com



More information about the sr-dev mailing list