[sr-dev] db_sqlite branch review request

Henning Westerholt henning.westerholt at 1und1.de
Wed Jun 1 12:35:03 CEST 2011

On Monday 30 May 2011, Timo Teräs wrote:
> The db_sqlite module is now getting ready for merge to master... It
> would be nice if it'd get some scrutiny from other developer before the
> merge, though.

Hi Timo,

I've had a quick look, just noticed some smaller things:

You implement your own str handling functions (str_dup), there are some 
already defined in ut.h file ([pkg,shm]_str_dup), maybe they are suitable for 

You've added some documentation in the files for the database functions, maybe 
you can convert them to the doxygen format (have a look to the /lib/srdb1/* 
files for examples, its should be not that difficult).

In your GPL headers, you use the  * $Id$ macro, this is not really necessary 
anymore in new modules as its not evaluated from git, maybe you can remove 

One question related to the db_sqlite_raw_query function, does sqlite really 
support arbitrary SQL functions? For example does is support SELECT DISTINCT, 
which is one query that the cr module uses.



More information about the sr-dev mailing list