[sr-dev] Fwd: git:master: core: support for receiving requests > 64kb on TCP

[Daniel-Constantin Mierla]

On 7/27/11 11:07 AM, Andrew Miller wrote:
> Daniel,
>
> The value in the structure (tcp_options.c line 117) is not a default, 
> it is a maximum. If this is not increased then setting tcp_rd_buf_size 
> > 64K has no effect; it truncates to 65536.
>
> The default (DEFAULT_TCP_BUF_SIZE tcp_init.h line 42) remains at 4069.
Right, the cfg framework has min/max limits for integers. I 
misinterpreted the commit log.

Thanks,
Daniel

>
> Andy
>
>>> *From:* Daniel-Constantin Mierla <miconda at gmail.com 
>>> <mailto:miconda at gmail.com>>
>>> *Date:* 27 July 2011 08:56:10 GMT+01:00
>>> *To:* Development mailing list of the sip-router project 
>>> <sr-dev at lists.sip-router.org <mailto:sr-dev at lists.sip-router.org>>
>>> *Cc:* Peter Dunkley <peter.dunkley at crocodile-rcs.com 
>>> <mailto:peter.dunkley at crocodile-rcs.com>>
>>> *Subject:* *Re: [sr-dev] git:master: core: support for receiving 
>>> requests > 64kb on TCP*
>>> *Reply-To:* miconda at gmail.com <mailto:miconda at gmail.com>
>>>
>>> Hello,
>>>
>>> If I haven't missed the purpose, this commit is not necessary. 
>>> Having the default value very big is not common in usual scenarios 
>>> and the value can be changed via global parameter:
>>> http://www.kamailio.org/dokuwiki/doku.php/core-cookbook:3.1.x#tcp_rd_buf_size
>>>
>>> tcp_rd_buf_size=16777216
>>>
>>> It should be set back to 64k unless the issue is something else.
>>>
>>> Cheers,
>>> Daniel
>>>
>>>
>>>
>>> On 7/25/11 11:55 AM, Peter Dunkley wrote:
>>>> Module: sip-router
>>>> Branch: master
>>>> Commit: 3c9a176bac4878983d324ce82354cd844b916373
>>>> URL: 
>>>> http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3c9a176bac4878983d324ce82354cd844b916373
>>>>
>>>> Author: pd<peter.dunkley at crocodile-rcs.com 
>>>> <mailto:peter.dunkley at crocodile-rcs.com>>
>>>> Committer: pd<peter.dunkley at crocodile-rcs.com 
>>>> <mailto:peter.dunkley at crocodile-rcs.com>>
>>>> Date:   Mon Jul 25 10:53:10 2011 +0100
>>>>
>>>> core: support for receiving requests>  64kb on TCP
>>>>
>>>> - Issue found and fixed by Andrew Miller at Crocodile RCS
>>>>
>>>> ---
>>>>
>>>>  tcp_options.c |    2 +-
>>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/tcp_options.c b/tcp_options.c
>>>> index 734f9fb..122965a 100644
>>>> --- a/tcp_options.c
>>>> +++ b/tcp_options.c
>>>> @@ -114,7 +114,7 @@ static cfg_def_t tcp_cfg_def[] = {
>>>>          "accept TCP messges without Content-Lenght "},
>>>>      /* internal and/or "fixed" versions of some vars
>>>>         (not supposed to be writeable, read will provide only 
>>>> debugging value*/
>>>> -    { "rd_buf_size", CFG_VAR_INT | CFG_ATOMIC,    512,    65536, 
>>>>  0,         0,
>>>> +    { "rd_buf_size", CFG_VAR_INT | CFG_ATOMIC,    512, 
>>>>    16777216,  0,         0,
>>>>          "internal read buffer size (should be>  max. expected 
>>>> datagram)"},
>>>>      { "wq_blk_size", CFG_VAR_INT | CFG_ATOMIC,    1,    65535,  0, 
>>>>         0,
>>>>          "internal async write block size (debugging use only for 
>>>> now)"},
>>>>
>>>>
>>>> _______________________________________________
>>>> sr-dev mailing list
>>>> sr-dev at lists.sip-router.org <mailto:sr-dev at lists.sip-router.org>
>>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>>>
>>> -- 
>>> Daniel-Constantin Mierla -- http://www.asipto.com
>>> Kamailio Advanced Training, Oct 10-13, Berlin: http://asipto.com/u/kat
>>> http://linkedin.com/in/miconda -- http://twitter.com/miconda
>>>
>
>
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla -- http://www.asipto.com
Kamailio Advanced Training, Oct 10-13, Berlin: http://asipto.com/u/kat
http://linkedin.com/in/miconda -- http://twitter.com/miconda

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20110727/2d7ade4d/attachment.htm>