[sr-dev] git:master: modules_s/register Prevented crash in case of incorrect uri

Marius Zbihlei marius.zbihlei at 1and1.ro
Fri Jan 14 16:26:38 CET 2011


Module: sip-router
Branch: master
Commit: 302d55cab249b25faf8bebb756a0cf5600607b3f
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=302d55cab249b25faf8bebb756a0cf5600607b3f

Author: Marius Zbihlei <marius.zbihlei at 1and1.ro>
Committer: Marius Zbihlei <marius.zbihlei at 1and1.ro>
Date:   Fri Jan 14 16:58:03 2011 +0200

modules_s/register Prevented crash in case of incorrect uri

Error logic performed a free_params on an garbage value (not initialized)
Reported by clang & llvm

---

 modules_s/registrar/save.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/modules_s/registrar/save.c b/modules_s/registrar/save.c
index 045e139..8550d3c 100644
--- a/modules_s/registrar/save.c
+++ b/modules_s/registrar/save.c
@@ -281,7 +281,7 @@ int parse_uri_dstip(str* received, struct ip_addr* ip, unsigned short* port,
 	struct sip_uri puri;
 	param_hooks_t hooks;
 	struct ip_addr* p;
-	param_t* params;
+	param_t* params = 0;
 	int error;
 
 	if (unlikely(!received)) return 0;




More information about the sr-dev mailing list