[sr-dev] [tracker] Task opened: dialog callbacks in pua_dialoginfo and mediaproxy

sip-router admin at sip-router.org
Wed Dec 28 20:55:29 CET 2011


THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened.  Details are below. 

User who did this - Jasmin Schnatterbeck (jasmin) 

Attached to Project - sip-router
Summary - dialog callbacks in pua_dialoginfo and mediaproxy
Task Type - Bug Report
Category - dialog
Status - Assigned
Assigned To - Timo Reimann
Operating System - All
Severity - Medium
Priority - Normal
Reported Version - Development
Due in Version - Undecided
Due Date - Undecided
Details - Hello,

in pua_dialoginfo() the dialog callback event "DLGCB_CONFIRMED_NA" is not handled (but registered for).
=> if 200 OK is received (but no ACK yet) pua_dialoginfo sends a dialog-terminated publish, what is not correct.

I propose to insert a new line after pua_dialoginfo.c:321 with:
"case DLGCB_CONFIRMED_NA:"

There is a similar thing in mediaproxy.c. It does not handle dialog-confirming ACKs (=ACKs for initial INVITEs) because it does not register for a corresponding callback. Dialog-confirming ACKs sometimes contain SDP, so I suggest to change mediaproxy.c:1955 to:

if (dlg_api.register_dlgcb(dlg, DLGCB_REQ_WITHIN | DLGCB_CONFIRMED,
__dialog_requests, (void*)ice_data, __free_dialog_data) != 0)

Jasmin

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=195

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.



More information about the sr-dev mailing list