[sr-dev] [tracker] Task opened: Record-Route and msg_apply_changes()

sip-router admin at sip-router.org
Wed Dec 28 20:40:34 CET 2011


THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened.  Details are below. 

User who did this - Jasmin Schnatterbeck (jasmin) 

Attached to Project - sip-router
Summary - Record-Route and msg_apply_changes()
Task Type - Bug Report
Category - Core
Status - Assigned
Assigned To - Andrei Pelinescu-Onciul
Operating System - All
Severity - Medium
Priority - Normal
Reported Version - Development
Due in Version - Undecided
Due Date - Undecided
Details - Hello,

in kamailio 3.2.1 Record-Route Header is inserted twice, if

- msg_apply_changes() is called after record_route()
  AND
- rr params are added after msg_apply_changes() 

I've just investigated record.c and I think the reason is, that add_rr_param() tries to recognize if rr has already been called/inserted depending on whether there is a corresponding lump for that - what is not the case, if msg_apply_changes() has been called before (I think it does not keep (but applies) lumps).

If that's correct, it's may possible to solve that (proposal):
- by adding a new message flag indicating whether rr has already been inserted or not and
- by creating a new lump anchor in add_rr_param() if rr has already been inserted and no lump is available for adding the rr param

Jasmin

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=194

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.



More information about the sr-dev mailing list