[sr-dev] git:master: pua: free parsed rr when sending subscribes

Daniel-Constantin Mierla miconda at gmail.com
Fri Dec 23 13:17:44 CET 2011


Module: sip-router
Branch: master
Commit: 1b3cfa60a5b5c7d435704d44b7c495b7e6aa84c8
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1b3cfa60a5b5c7d435704d44b7c495b7e6aa84c8

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date:   Fri Dec 23 12:48:42 2011 +0100

pua: free parsed rr when sending subscribes

- reported by Laura Testi

---

 modules_k/pua/send_subscribe.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/modules_k/pua/send_subscribe.c b/modules_k/pua/send_subscribe.c
index 50560db..8d358a3 100644
--- a/modules_k/pua/send_subscribe.c
+++ b/modules_k/pua/send_subscribe.c
@@ -897,6 +897,8 @@ int send_subscribe(subs_info_t* subs)
 	db1_res_t *res=NULL;
 	ua_pres_t dbpres;
 	str pres_uri={0,0}, watcher_uri={0,0}, extra_headers={0,0};
+	dlg_t* td= NULL;
+
 
 	memset(&dbpres, 0, sizeof(dbpres));
 	dbpres.pres_uri = &pres_uri;
@@ -1120,8 +1122,6 @@ insert:
 		}	
         */
 
-		dlg_t* td= NULL;
-
 		if (subs->internal_update_flag == INTERNAL_UPDATE_TRUE)
 		{
 			LM_INFO("attempting to re-SUBSCRIBE on internal (rls_update_subs()) update - skipping\n");
@@ -1170,14 +1170,16 @@ insert:
 			LM_ERR("while sending request with t_request\n");
 			goto done;
 		}
+	}
+
 
+done:
+	if(td!=NULL) {
 		if(td->route_set)
 			free_rr(&td->route_set);
 		pkg_free(td);
 		td= NULL;
 	}
-
-done:
 	pkg_free(str_hdr);
 	free_results_puadb(res);
 	return ret;




More information about the sr-dev mailing list