[sr-dev] [tracker] Task opened: a74f12d6 (3.2) registrar breaks save(..., 0x4) functionality (Attachment added)

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened.  Details are below. 

User who did this - Walter Doekes (wdoekes) 

Attached to Project - sip-router
Summary - a74f12d6 (3.2) registrar breaks save(..., 0x4) functionality
Task Type - Bug Report
Category - registrar (k)
Status - Assigned
Assigned To - Daniel-Constantin Mierla
Operating System - All
Severity - Medium
Priority - Normal
Reported Version - Development
Due in Version - Undecided
Due Date - Undecided
Details - Hi,

I'm trying to maintain only one Contact per AOR. But I want the last register to count:

http://www.kamailio.org/docs/modules/3.2.x/modules_k/registrar.html#id2494545 
modparam("registrar", "max_contacts", 1)

http://www.kamailio.org/docs/modules/3.2.x/modules_k/registrar.html#id2497967
save("location", 0x4);

This fails. As far as I can see because this got added in a74f12d6:

a74f12d6 (Daniel-Constantin Mierla 2011-06-04 10:22:09 +0200 566)       if (cfg_get(registrar, registrar_cfg, max_contacts)) {
a74f12d6 (Daniel-Constantin Mierla 2011-06-04 10:22:09 +0200 567)               _c = get_first_contact(_m);
a74f12d6 (Daniel-Constantin Mierla 2011-06-04 10:22:09 +0200 568)               if(test_max_contacts(_m, _r, _c, ci) != 0)
a74f12d6 (Daniel-Constantin Mierla 2011-06-04 10:22:09 +0200 569)                       goto error;
a74f12d6 (Daniel-Constantin Mierla 2011-06-04 10:22:09 +0200 570)       }

After all, the _mode -- which supposedly contains whether it should overwrite existing contacts -- isn't checked here.

Attached, a patch that fixes it. I am however a little confused by the naming of _mode and REG_SAVE_REPL_FL. Neither conveys any meaning about what we're trying to do; which is overwriting (REG_SAVE_OVERWRITE_FL? _should_overwrite?)

Have I misunderstood the documentation?

Regards,
Walter Doekes
OSSO B.V.

One or more files have been attached.

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=192

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.