[sr-dev] [tracker] Comment added: Kamailio 3.2.1 Dialog Crash

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#186 - Kamailio 3.2.1 Dialog Crash
User who did this - Jasmin Schnatterbeck (jasmin)

----------
another thing:

"dlg_get_msg_dialog" calls "pre_match_parse"

so I got LM_ERROR "failed to get From header" for each request without from tag (unfortunately many UAs still send sip msgs without from tag).

So another suggestion (just for logging purposes) ... in "pre_match_parse":


         if (parse_from_header(req)<0 || get_from(req)->tag_value.len==0) {
                 LM_ERR("failed to get From header\n");
                return -1;
         }

to:

  if (parse_from_header(req)<0 ) {
                LM_ERR("failed to get From header\n");
               return -1;
       }

       if (get_from(req)->tag_value.len==0) {
               LM_DBG("no From tag found - request without From tag?\n");
                return -1;
       }

Jasmin
----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=186#comment444

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.