[sr-dev] git:master: modules_k/dialog: Provider helper get_valid_msg() to retrieve

Timo Reimann timo.reimann at 1und1.de
Wed Aug 17 17:28:53 CEST 2011


Hey Daniel,


On 17.08.2011 14:24, Daniel-Constantin Mierla wrote:
> if I havent missed something, at the first sight (including your next
> commit), since the other modules do not link directly against dialog module:
> - either make the get_valid_msg() inline and put it all in dlg_cb.h
> - or export it through dialog inter module API and use it from there in
> the other modules
> 
> As personal preference, at least for first case, I would prefix it with
> dlg_, like dlg_get_valid_msg() -- more suggestive about its origin and
> higher chances to avoid naming conflicts.

Done! I turned the function static inline and prefixed its name with "dlg_".

Thanks for the hint.


Cheers,

--Timo



More information about the sr-dev mailing list