[sr-dev] git:master: modules_k/nathelper: Add is_rfc1918(ip_addr) function to test ip_addr for rfc1918addresses.

[Iñaki Baz Castillo]

2011/8/1 Henning Westerholt <henning.westerholt at 1und1.de>:
> ok, understand. I think we should not introduce two functions with similar
> names and the same behaviour in two modules. Even worse, both use different
> implementations (table matching vs. ragel parser). So one commit should be
> reverted.

I agree.


> A generic is_rfc1918 function in ipops would be nice, but the nathelper module
> also needs this test internally. What about move one of the parsers to the
> library dir, and then just including it from both modules?

It would be nice. Is there an already existing library file in which
such function would fit well?


-- 
Iñaki Baz Castillo
<ibc at aliax.net>