[sr-dev] [tracker] Task changed: Provide processed message in tm callbacks whenever possible

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has been changed.  The changes are listed below.  For full information about what has changed, visit the URL and click the History tab.

FS#123 - Provide processed message in tm callbacks whenever possible
User who did this: Timo Reimann (tr)
Task details edited:
-------
In Kamailio 1.5, certain callbacks (namely TMCB_RESPONSE_PRE_OUT,
TMCB_RESPONSE_OUT, and TMCB_REQUEST_BUILT) provided the entire processed message (i.e., after headers were modified) in tmcb_params->extra1 as *str. AFAICS, sr's equivalent to that parameter is send_buf in the tmcb_params structure. However, the only sr callbacks that do provide the processed messages are TMCB_REQUEST_SENT and TMCB_RESPONSE_SENT which, had no perfect correspondency in Kamailio (*_OUT callbacks would not be called for retransmissions).

Technically, this makes complete sense because the two *_SENT callbacks and the send_buf variable are available only when WITH_ONSEND is defined. Also, I noticed that these callbacks are handled through run_onsend_callbacks2() instead of run_trans_callbacks(). Only the former fill send_buf and hence pass processed messages as part of the callback.

Please pass processed messages for all callbacks where a processed message is supposed to be available, i.e., all *_OUT and *_READY callbacks.

(An email on the sr-dev list was originally posted by me on 28.7.2011. See [[http://lists.sip-router.org/pipermail/sr-dev/2010-July/008351.html|here]])
-------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=123

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.