[sr-dev] [tracker] Comment added: make install fails with a bash syntax error

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#87 - make install fails with a bash syntax error
User who did this - Dmitry Goncharov (Dmitry)

----------
Yes, the change is moving 'do' to the next line.
This small bash session demonstrates the problem.

$
$ git remote -v
origin  git://git.sip-router.org/sip-router (fetch)
origin  git://git.sip-router.org/sip-router (push)
$ git br
* kamailio_3.0
  master
$ git st
# On branch kamailio_3.0
nothing to commit (working directory clean)
$ make install-cfg
Makefile.defs defs skipped
/bin/sh: -c: line 18: syntax error near unexpected token `fi'
/bin/sh: -c: line 18: `                         fi ; \'
make: *** [install-cfg] Error 1
$ patch -p1 < ../kamailio-3.0.3-makefile.diff
patching file Makefile
$ git diff | cat
diff --git a/Makefile b/Makefile
index 210d277..90f6b21 100644
--- a/Makefile
+++ b/Makefile
@@ -918,7 +918,8 @@ install-cfg: $(cfg_prefix)/$(cfg_dir)
                        fi; \
                fi
                @# other configs
-               @for r in $(C_INSTALL_CFGS) ""; do \
+               @for r in $(C_INSTALL_CFGS) ""; \
+               do \
                        if [ -n "$$r" ]; then \
                                if [ -f "$$r" ]; then \
                                        n=`basename "$$r"` ; \
$ make install-cfg
Makefile.defs defs skipped
# radius dictionary
touch           //etc/kamailio//dictionary.kamailio
install -m 644 etc/dictionary.kamailio //etc/kamailio/
$
$
$
$ bash --version
GNU bash, version 4.1.7(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
$ make --version
GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for x86_64-pc-linux-gnu
$


This reproduces on two x86_64 gentoo.
This does not reproduce on i686 gentoo with same bash and make.
Also, this does not reproduce with bash 3.2.39(1)-release and the same make on i686 ubuntu.
Maybe something is broken on both of my x86_64.
 
----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=87#comment118

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.