[sr-dev] git:master: modules/ carrierroute Improved documentation of carrierroute reply_code field

Marius Zbihlei marius.zbihlei at 1and1.ro
Thu Oct 28 12:42:15 CEST 2010


Module: sip-router
Branch: master
Commit: cfc11b8892742697c9184e942ba2113f419428dd
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cfc11b8892742697c9184e942ba2113f419428dd

Author: Marius Zbihlei <marius.zbihlei at 1and1.ro>
Committer: Marius Zbihlei <marius.zbihlei at 1and1.ro>
Date:   Thu Oct 28 13:37:00 2010 +0300

modules/carrierroute Improved documentation of carrierroute reply_code field

The documentation didn't make it clear that regex are _not_ supported.
Thanks go to Iñaki Baz Castillo for reporting.

---

 modules/carrierroute/README                     |   14 ++++++++------
 modules/carrierroute/doc/carrierroute_admin.xml |    5 +++--
 2 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/modules/carrierroute/README b/modules/carrierroute/README
index 1c28e22..8c43796 100644
--- a/modules/carrierroute/README
+++ b/modules/carrierroute/README
@@ -976,12 +976,14 @@ domain register {
    for example that indicates that ringing has happened. If this flag is
    set, there will be no further forwarding, because next_domain is empty.
    In the second and third routes are certain gateway errors matched, if
-   this errors have occured, then the next domain will be choosen. The
-   last route does forwarding according some flags, e.g. the customer came
-   from a certain carrier, and has call-forwarding deactivated. In order
-   to use the routing that is specified above, a matching carrierroute
-   table must be provided, that holds domain entries for this routing
-   rules. Not all table colums are show here for brevity.
+   this errors have occured, then the next domain will be choosen. Note
+   that the reply_code must be 3 characters wide, and only the "."
+   character is accepted as wildcard.The last route does forwarding
+   according some flags, e.g. the customer came from a certain carrier,
+   and has call-forwarding deactivated. In order to use the routing that
+   is specified above, a matching carrierroute table must be provided,
+   that holds domain entries for this routing rules. Not all table colums
+   are show here for brevity.
 
    Example 1.23. Example database content - carrier_name table
 ...
diff --git a/modules/carrierroute/doc/carrierroute_admin.xml b/modules/carrierroute/doc/carrierroute_admin.xml
index d30bb29..e4d30d3 100644
--- a/modules/carrierroute/doc/carrierroute_admin.xml
+++ b/modules/carrierroute/doc/carrierroute_admin.xml
@@ -1083,8 +1083,9 @@ domain register {
 			for example that indicates that ringing has happened. If this flag is set,
 			there will be no further forwarding, because next_domain is empty. In the
 			second and third routes are certain gateway errors matched, if this errors
-			have occured, then the next domain will be choosen. The last route does
-			forwarding according some flags, e.g. the customer came from a certain carrier,
+			have occured, then the next domain will be choosen. Note that the reply_code must be
+			3 characters wide, and only the "." character is accepted as wildcard.The last route
+			does forwarding according some flags, e.g. the customer came from a certain carrier,
 			and has call-forwarding deactivated. In order to use the routing that is
 			specified above, a matching carrierroute table must be provided, that holds
 			domain entries for this routing rules. Not all table colums are show here for




More information about the sr-dev mailing list