[sr-dev] [tracker] Comment added: presence_xml with db_postgres

sip-router admin at sip-router.org
Thu Jun 24 19:11:33 CEST 2010


THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#77 - presence_xml with db_postgres
User who did this - Henning Westerholt (henningw)

----------
Indeed the BLOBs in db_mysql driver module are also null-terminated. This behaviour is really old, its has been this way since 0.9 times. But you're right, BLOBs normally don't need to be inserted this way. I could guess it was done in the past because BLOBs were not represented as own dedicated datatype this time, but as VAL_STR values. In 1.0 the postgres module did some null-termination, in 1.0 it was replaced and the internal (un) escaping routines were used instead.

The correct way would be probably to fix the modules that they don't rely on this anymore. But as i've no way of testing all this presence stuff, and it only saves one byte, i think we should apply this patch. Then its at least consistent to db_mysql and db_unixodbc.
----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=77#comment89

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.



More information about the sr-dev mailing list