[sr-dev] [tracker] Comment added: patch to add method masking to xlog function

sip-router admin at sip-router.org
Tue Jul 27 11:39:48 CEST 2010


THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#81 - patch to add method masking to xlog function
User who did this - Daniel-Constantin Mierla (miconda)

----------
I am not the owner of the module, anyway anyone is welcome to comment, plus that this is one change that impacts every config  :-) .

Why you don't add a new function xlogf() - the function that will evaluate built-in filters before printing. In the future someone might desire other type of filters.

Also, just a suggestion, I saw you added dedicated rpc function to change the filters - while this is fine, there is now the cfg parameter framework which seems to be built for such cases (changing core/module parameters at runtime with smallest impact). I think Marius converted some parameters of registrar(k) module. Maybe you check this option and see if is more appropriate here as well.
----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=81#comment101

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.



More information about the sr-dev mailing list