[sr-dev] SF.net SVN: openser:[6039] branches/1.5/modules/dialog

[Timo Reimann]

Revision: 6039
          http://openser.svn.sourceforge.net/openser/?rev=6039&view=rev
Author:   timoreimann
Date:     2010-08-05 16:26:56 +0000 (Thu, 05 Aug 2010)

Log Message:
-----------
modules/dialog: Revert "Prevent 'unable to find dialog' WARN messages
caused by accessing a dialog in the "deleted" state".

The approach chosen was incomplete as it requires extending checks of
return values for all calls to get_dlg() and lookup_dlg() against
POINTER_CLOSED_MARKER. Otherwise, it may lead to server crashes when
code mistakes POINTER_CLOSED_MARKER for an existing dialog. However,
having to check against two return values requires a lot of logic
changes.

Therefore, a better approach will be taken in a follow-up commit.

This reverts release 6027.

Modified Paths:
--------------
    branches/1.5/modules/dialog/dlg_cb.c
    branches/1.5/modules/dialog/dlg_handlers.c
    branches/1.5/modules/dialog/dlg_hash.c
    branches/1.5/modules/dialog/dlg_hash.h


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.