[sr-dev] Enum PV lookup

[Klaus Darilion]

Am 06.04.2010 14:09, schrieb Alex Hermann:
> On Saturday 03 April 2010, Juha Heinanen wrote:
>> based on the readme, that is what it should do, because "the user part
>> of the RURI is still used in the NAPTR regexp".  don't ask me why,
>> because i did not write that function.  it was provided by Greg Fausak
>> <lgfausak at gmail.com>  and here is the original description:
>>
>>    Most of the time you want to route based on the RURI. On rare
>>    occasions you may wish to route based on the user part of the
>>    "From:" tag, analogous to source based policy routing in the
>>    ip world. The function enum_fquery mimics the behaviour of the
>>    enum_query function except the user part of the "From:" is
>>    used for the enum lookup instead of the user part of the RURI.
>>    Obviously the user part of the RURI is still used in the naptr
>>    regexp.
>>
>> i don't know if anyone is still using enum_pv_query.  if not, then it
>> could be changed to use the number in the pv also where the regex is
>> applied to.
>
>
> Why have multiple separate functions for the same functionality? These enum
> functions could from the beginning have been defined as 'enum_query($lookup,
> $suffix, $service, $regexp_subject)' with all arguments pv's or static
> strings. The common use case would be enum_query($rU, ...).

The ENUM module is older than PV support, and also in early days the 
module functions only supported 2 parameters.


regards
klaus

>