[sr-dev] Enum PV lookup

[Jasmin Schnatterbeck]

Am Dienstag, den 06.04.2010, 11:34 +0200 schrieb Klaus Darilion:
> 
> Am 03.04.2010 08:24, schrieb Juha Heinanen:
> > based on the readme, that is what it should do, because "the user part
> > of the RURI is still used in the NAPTR regexp".  don't ask me why,
> > because i did not write that function.  it was provided by Greg Fausak
> > <lgfausak at gmail.com>  and here is the original description:
> >
> >    Most of the time you want to route based on the RURI. On rare
> >    occasions you may wish to route based on the user part of the
> >    "From:" tag, analogous to source based policy routing in the
> >    ip world. The function enum_fquery mimics the behaviour of the
> >    enum_query function except the user part of the "From:" is
> >    used for the enum lookup instead of the user part of the RURI.
> >    Obviously the user part of the RURI is still used in the naptr
> >    regexp.
> >
> > i don't know if anyone is still using enum_pv_query.  if not, then it
> > could be changed to use the number in the pv also where the regex is
> > applied to.
> 
> True. Using the PV only for the DNS lookup, but using the request URI 
> for the regexp is very strange.
> 

I think so as well - it would make much more sense to use the PV value
only in this function...

jasmin

> I vote for using the PV for the regexp too.
> 
> klaus
> 
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev