[sr-dev] [ openser-Bugs-2851214 ] Registrar leaks contacts from unrelated users

[SourceForge.net]

Bugs item #2851214, was opened at 2009-09-04 14:26
Message generated for change (Settings changed) made by henningw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2851214&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.5.x
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Alex Hermann (axlh)
>Assigned to: Henning Westerholt (henningw)
Summary: Registrar leaks contacts from unrelated users

Initial Comment:
When an AOR with no active registrations queries for its current bindings (Contact: *, Expires: 0), the registrar returns the bindings of the AOR who was last handled by the same process instead of returning an empty list. Attached patch fixes this. Applies to 1.4 as well as 1.5.

Btw, why does every caller of get_urecord() check for negative return code??? The function can only return 0 or 1.

----------------------------------------------------------------------

>Comment By: Henning Westerholt (henningw)
Date: 2009-09-04 16:13

Message:
Thanks for the patch Alex, i've applied it to the 1.3, 1.4 and 1.5
branches. With regards to your question, indeed this is strange. Perhaps in
the past the function used to return a negative return value? Patches for
this (against the sr master branch) are ok course welcome. :-)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2851214&group_id=139143