[sr-dev] git:master: tm: Number of fixes in code and documentation for serial forking.

[Juha Heinanen]

Jan Janak writes:

 > This commit includes a number of changes I have done to the serial
 > forking code in tm. The original version crashed sip-router and timers
 > and other things did not work properly. I have tested the code and it
 > seems to be working fine now, including all the things we discussed in
 > other threads.

thanks jan for the very thorough work on t_serial.

 > There is only one incompatible change. The value of fr_inv_timer_next
 > is now in milliseconds. The previous version used seconds, but it did
 > not work in sip-router anyway. All other tm timers use milliseconds,
 > so we are now consistent.

it is better that all timers use milliseconds, because it would be
confusing if some would be in seconds and some in milliseconds.

 > I merged this commit also into sr_3.0 branch, because in addition to
 > the new documentation this is all bugfixes. I think that this commit
 > should also be merged into kamailio_3.0 branch, because the original
 > code does not seem to work well with sip-router core.

let daniel do it because it was his idea to break the one core+tm model.

 > Please give it a try in your configuration if you have the time and
 > let me know if something does not work.

i'll test it later today.

by the way, this encoding/decoding business in the code is ugly.  if i
remember correctly, AVPs can now have also structure values.  if so,
encoding/decoding could be avoided.

-- juha