[sr-dev] [ openser-Bugs-2897594 ] uac_auth does't work in 3.0

[SourceForge.net]

Bugs item #2897594, was opened at 2009-11-14 10:14
Message generated for change (Comment added) made by mangust2
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2897594&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Mangust (mangust2)
Assigned to: Nobody/Anonymous (nobody)
Summary: uac_auth does't work in 3.0

Initial Comment:
in file modules_k/uac/auth.c

line 235:

        for( hdr=rpl->headers ; hdr ; hdr=hdr->next )
        {
// -->>             if ( hdr->type!=HDR_OTHER_T)
// -->>                     continue;
                if (cmp_hdrname_str(&hdr->name, &hdr_name)==0)
                        return hdr;
        }

commented out line prevent from recognizing authentication field causing error.
Nov 14 04:02:28 v /usr/local/sbin/kamailio[24361]: ERROR: uac [auth.c:244]: reply has no auth hdr (WWW-Authenticate)
Nov 14 04:02:28 v /usr/local/sbin/kamailio[24361]: ERROR: uac [auth.c:419]: failed to extract authenticate hdr


maybe because authentication now not HDR_OTHER_T but 
        HDR_WWW_AUTHENTICATE_T                 /* WWW-Authenticate header field */,
        HDR_PROXY_AUTHENTICATE_T               /* Proxy-Authenticate header field */,
according to:
http://www.asipto.com/pub/kamailio-devel-guide/

for a moment i just comment it out
will also try:
                if ( hdr->type!=HDR_WWW_AUTHENTICATE_T && hdr->type!=HDR_PROXY_AUTHENTICATE_T )
                        continue;
                if (cmp_hdrname_str(&hdr->name, &hdr_name)==0)
                        return hdr;


----------------------------------------------------------------------

>Comment By: Mangust (mangust2)
Date: 2009-11-14 10:20

Message:
yes, this work as well:

for( hdr=rpl->headers ; hdr ; hdr=hdr->next )
{
if ( hdr->type!=HDR_WWW_AUTHENTICATE_T &&
hdr->type!=HDR_PROXY_AUTHENTICATE_T )
continue;
if (cmp_hdrname_str(&hdr->name, &hdr_name)==0)
return hdr;
}


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2897594&group_id=139143