[SR-Dev] git:master: * Moved lcr module from modules_k to modules and removed it from modules_s .

[Daniel-Constantin Mierla]

Hello,

On 05/11/2009 11:50 AM, Juha Heinanen wrote:
> Daniel-Constantin Mierla writes:
>
>  > It is 100, indeed for fifo. Checking the code, I think has to be 
>  > PROC_NOCHILDINIT because the MI calls a different child init function 
>  > that is added in the mi_export_t structure. Therefore module's child 
>  > init should not be called for MI processes.
>
> daniel,
>
> indeed, in lcr module i have
>
> static mi_export_t mi_cmds[] = {
>     { MI_LCR_RELOAD, mi_lcr_reload, MI_NO_INPUT_FLAG, 0, mi_child_init },
>     { MI_LCR_GW_DUMP, mi_lcr_gw_dump, MI_NO_INPUT_FLAG, 0, 0 },
>     { MI_LCR_LCR_DUMP, mi_lcr_lcr_dump, MI_NO_INPUT_FLAG, 0, 0 },
>     { 0, 0, 0, 0 ,0}
> };
>
> and
>
> static int mi_child_init(void)
> {
> 	return lcr_db_init(&db_url);
> }
>
> also, i lcr module i don't have any other child_init function defined.
>
> my conclusion thus is that lcr module db initialization is exactly as it
> should be.
>   
I have changed that the MI processes are started with PROC_NOCHLDINIT. 
The init should be now as in K - mi processes call only mi_child_init. 
Anyhow, probably it was pretty ok before as well -- I tested mi fifo 
several times without any issue -- now is just safer.

Cheers,
Daniel

-- 
Daniel-Constantin Mierla
http://www.asipto.com/