[SR-Dev] [PATCH 06/10] Remove last parameter from calls to register_tmcb

Ovidiu Sas osas at voipembedded.com
Tue Mar 3 01:24:39 CET 2009


The last parameter from the register_tmcb is vital for the dialog
module from kamailio to work properly.
The tm modules should be merged instead of removing functionality from
kamailio modules.

Regards,
Ovidiu Sas

On Mon, Mar 2, 2009 at 7:16 PM, Jan Janak <jan at iptel.org> wrote:
> In the kamailio version of tm module function register_tmcb accepts an
> extra parameter, some kind of clean up function. There is no such
> parameter in ser and thus sip-router (remember, we imported tm from
> ser) and thus we need to remove the parameter here too.
>
> In acc module it was set to 0 anyway so there is no harm done.
> ---
>  modules/acc/acc_logic.c |    2 +-
>  modules/acc/acc_mod.c   |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/modules/acc/acc_logic.c b/modules/acc/acc_logic.c
> index 4182a92..e92d827 100644
> --- a/modules/acc/acc_logic.c
> +++ b/modules/acc/acc_logic.c
> @@ -241,7 +241,7 @@ void acc_onreq( struct cell* t, int type, struct tmcb_params *ps )
>                        TMCB_RESPONSE_IN |
>                        /* report on missed calls */
>                        ((is_invite && is_mc_on(ps->req))?TMCB_ON_FAILURE:0) ;
> -               if (tmb.register_tmcb( 0, t, tmcb_types, tmcb_func, 0, 0 )<=0) {
> +               if (tmb.register_tmcb( 0, t, tmcb_types, tmcb_func, 0)<=0) {
>                        LM_ERR("cannot register additional callbacks\n");
>                        return;
>                }
> diff --git a/modules/acc/acc_mod.c b/modules/acc/acc_mod.c
> index 7e234e6..a9da577 100644
> --- a/modules/acc/acc_mod.c
> +++ b/modules/acc/acc_mod.c
> @@ -401,7 +401,7 @@ static int mod_init( void )
>        }
>
>        /* listen for all incoming requests  */
> -       if ( tmb.register_tmcb( 0, 0, TMCB_REQUEST_IN, acc_onreq, 0, 0 ) <=0 ) {
> +       if ( tmb.register_tmcb( 0, 0, TMCB_REQUEST_IN, acc_onreq, 0) <=0 ) {
>                LM_ERR("cannot register TMCB_REQUEST_IN callback\n");
>                return -1;
>        }
> --
> 1.5.6.5
>
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>



More information about the sr-dev mailing list