[SR-Dev] git:master: A comment warning about flag FL_REQ_UPSTREAM.

Jan Janak jan at iptel.org
Tue Mar 3 01:06:20 CET 2009


Module: sip-router
Branch: master
Commit: 00dbf3d788404cd97821e4d5873e843b4f0aec4e
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=00dbf3d788404cd97821e4d5873e843b4f0aec4e

Author: Jan Janak <jan at iptel.org>
Committer: Jan Janak <jan at iptel.org>
Date:   Mon Mar  2 23:20:31 2009 +0100

A comment warning about flag FL_REQ_UPSTREAM.

This patch adds a comment warning about flag FL_REQ_UPSTREAM which is
defined in kamailio module acc and uses the value (1<<11) in sip message
flags. This flags was originally defined in this file, but since the
kamailio acc module is the only module setting and using the flag.

I think it would make more sense to define it in the module itself
before we merge ser and kamailio acc implementations (then the flag
probably won't be needed anymore because the test for the direction of
the message is trivial and there is no need to set the flag in the sip
message, especially if it is not being used by any other module).

Signed-off-by: Jan Janak <jan at iptel.org>

---

 parser/msg_parser.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/parser/msg_parser.h b/parser/msg_parser.h
index 98f98aa..b1541b7 100644
--- a/parser/msg_parser.h
+++ b/parser/msg_parser.h
@@ -96,6 +96,10 @@ enum request_method { METHOD_UNDEF=0, METHOD_INVITE=1, METHOD_CANCEL=2, METHOD_A
 #define FL_MTU_TCP_FB   (1 << 8)
 #define FL_MTU_TLS_FB   (1 << 9)
 #define FL_MTU_SCTP_FB  (1 << 10)
+
+/* WARNING: Value (1 << 11) is temporarily reserved for use in kamailio acc
+ * module (flag FL_REQ_UPSTREAM)! */
+
 #define FL_MTU_FB_MASK  (FL_MTU_TCP_FB|FL_MTU_TLS_FB|FL_MTU_SCTP_FB)
 
 




More information about the sr-dev mailing list