[sr-dev] [ openser-Bugs-2824350 ] Presence DB support completely broken

[SourceForge.net]

Bugs item #2824350, was opened at 2009-07-20 15:49
Message generated for change (Comment added) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2824350&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.5.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Alex Hermann (axlh)
Assigned to: Nobody/Anonymous (nobody)
Summary: Presence DB support completely broken

Initial Comment:
As subject.

commit 5840 did the damage

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2009-07-20 17:52

Message:
fallback to db is in presence and the insert function is used by rls module
as well. I had no time to check the impact now.

With this idea, to be safe, fallback2db param has to be directed to
another variable, fallback2db initialized to 0 and set to param value in
each child, via child_init. Otherwise can be a conflict of loading order.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2009-07-20 16:37

Message:
I don't know if changing the API and ABI is appropriate for the stable
series. 

What about setting the fallback2db variable only AFTER loading the DB
contents?


----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2009-07-20 16:22

Message:
The function is used in presence and rls modules. Does not look like big
changes to add a new param to specify the mode. Do you think of something
else?

----------------------------------------------------------------------

Comment By: Alex Hermann (axlh)
Date: 2009-07-20 16:07

Message:
New subscriptions don't get stored in the DB because the test for
'fallback2db' was wrong.

I just noticed the insert_shtable() function is also used to load from DB
initially, so my patch is wrong. Fix is a bit more non-trivial.

The problem is that the function is used for both DB-load at startup and
new subscriptions during runtime. The db_flag in the hash table record
needs to be INSERTDB_FLAG during runtime, and NO_UPDATEDB_FLAG for initial
load.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2009-07-20 15:53

Message:
Please provide a bit more details of what got broken.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2824350&group_id=139143