[sr-dev] git:master: tmx(k): remove unnecessary reply locking

Andrei Pelinescu-Onciul andrei at iptel.org
Tue Jul 14 18:19:28 CEST 2009


Module: sip-router
Branch: master
Commit: 51aeea7d5197ca44d5aabd46085c6c1661a98d73
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=51aeea7d5197ca44d5aabd46085c6c1661a98d73

Author: Andrei Pelinescu-Onciul <andrei at iptel.org>
Committer: Andrei Pelinescu-Onciul <andrei at iptel.org>
Date:   Tue Jul 14 18:18:02 2009 +0200

tmx(k): remove unnecessary reply locking

- reply locking is not needed around prepare_to_cancel() (former
  which_cancel()).

---

 modules_k/tmx/tmx_mod.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/modules_k/tmx/tmx_mod.c b/modules_k/tmx/tmx_mod.c
index 5b8cd9c..ce2e61d 100644
--- a/modules_k/tmx/tmx_mod.c
+++ b/modules_k/tmx/tmx_mod.c
@@ -231,23 +231,19 @@ static int t_cancel_branches(struct sip_msg* msg, char *k, char *s2)
 	n = (int)k;
 	switch(n) {
 		case 1:
-			LOCK_REPLIES(t);
 			/* prepare cancel for every branch except idx */
 			_tmx_tmb.prepare_to_cancel(t, &cb, 1<<idx);
-			UNLOCK_REPLIES(t);
 		case 2:
 			if(msg->first_line.u.reply.statuscode>=200)
 				break;
 			cb = 1<<idx;
 		break;
 		default:
-			LOCK_REPLIES(t);
 			if (msg->first_line.u.reply.statuscode>=200)
 				/* prepare cancel for every branch except idx */
 				_tmx_tmb.prepare_to_cancel(t, &cb, 1<<idx);
 			else
 				_tmx_tmb.prepare_to_cancel(t, &cb, 0);
-			UNLOCK_REPLIES(t);
 	}
 	LM_DBG("canceling %d/%d\n", n, (int)cb);
 	if(cb==0)




More information about the sr-dev mailing list