[SR-Dev] TLS merge

[Jan Janak]

On 24-02 11:15, Andrei Pelinescu-Onciul wrote:
> On Feb 23, 2009 at 23:51, Daniel-Constantin Mierla <miconda at gmail.com> wrote:
> > Hello,
> > 
> > On 02/23/2009 11:02 PM, Jan Janak wrote:
> > > Hello,
> > >
> > > If we want to make the sip-router core usable in both projects, we would also
> > > need to merge both tls implementations. In SER we moved the the TLS
> > > implementation into tls module.
> > >
> > > In Kamailio it appears that the tls implementation is in tls subdirectory in
> > > the core and then there is tlsops module which contains pseudovariables used
> > > to retrieve information from TLS certificates.
> > >
> > > Unless somebody has a better idea, I would propose that we merge the tls
> > > implementation from kamailio core into ser tls module. In addition to that we
> > > could merge the implementation of tls related pseudovariables from tlsops into
> > > the tls module and then put the tls module into the sip-router repository.
> > >
> > > What do you think?
> > yes, tls has to be merged and keeping it as module is fine for me.
> > 
> > Does the ser core (sip router) still needs to be compiled with some TLS 
> > define in order to get the TLS support, or it is implicit and just 
> > loading the module will do it?
> 
> No, it's implicit. You have to set enable_tls in .cfg and load the tls
> module (if you don't load it and have enable_tls=yes you'll get a
> warning). There is also a define: TLS_HOOKS but's it's set by default.

  Is the variable enable_tls really needed? Can't we get rid of it? Or maybe
  set it automatically when the tls module is loaded?

    Jan.