[sr-dev] add_contact_alias()

Juha Heinanen jh at tutpro.com
Tue Dec 22 18:13:35 CET 2009


Klaus Darilion writes:

 >  > +    /* Compare source ip and port against contact uri */
 > +    if ((ip = str2ip(&(uri.host))) == NULL) {
 > +       LM_ERR("contact uri host is not an ip address\n");
 > +       return -1;
 > +    }
 > 
 > Why do you in return -1 in case of a domain instead of adding the alias 
 > parameter in this case too?

that is because of the current definition of add_contact_alias():

6.14.  add_contact_alias()

   Adds ;alias=ip:port parameter to contact URI containing received
   ip:port if contact uri ip:port does not match received ip:port.

 > 2. AFAIS the new functions are included in sr3.0 branch, but not in 
 > kamailio-3.0 branch. Why?

current practice seem to be that if someone needs something from the
other branch (k or sr), then he/she needs to sherry pick the commits
from the other branch.

-- juha



More information about the sr-dev mailing list