[Serdev] [Tracker] Created: (SER-389) Makefile system: err_fail=1 not catching all problems

[Jan Janak (JIRA)]

Makefile system: err_fail=1 not catching all problems
-----------------------------------------------------

                 Key: SER-389
                 URL: http://tracker.iptel.org/browse/SER-389
             Project: SER
          Issue Type: Bug
    Affects Versions: Ipteldorf
            Reporter: Jan Janak


In shell fragments like:

	@for r in $(share_files) "" ; do \
		if [ -n "$$r" ]; then \
			if [ -f "$$r" ]; then \
				$(INSTALL_TOUCH) \
					$(share_prefix)/$(share_dir)/`basename "$$r"` ; \
				$(INSTALL_SHARE)  "$$r"  $(share_prefix)/$(share_dir) ; \
			else \
				echo "ERROR: $$r not found" ; \
				if [ ${err_fail} = 1 ] ; then \
					exit 1; \
				fi ; \
			fi ;\
		fi ; \
	done; true

errors in INSTALL_TOUCH or INSTALL_SHARE would not be reported if err_fails is set to 1. This can happen when INSTALL_TOUCH fails due to permissions problems, for example. Maybe we could use something like set -e in the shell fragments, or something like that?


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tracker.iptel.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira