[Serdev] t_is_canceled() useless?

[Martin Hoffmann]

Andrei Pelinescu-Onciul wrote:
> 
> It should return true also for an e2e cancel. The problem here is if we
>  set T_CANCELED for any cancel attempts (always) or only for cancel to
>  transactions that haven't received a 2xx.
> OTOH I  think it doesn't matter if we set it every time (a 2xx replied 
> transaction would be on its final wait timer anyway, it won't even look
> at the T_CANCELED flag) and I think it can be set w/o locking replies
> (in the wrost case it will race w/ setting T_6xx, but it shouldn't be a 
> problem).

Admittedly, I don't quite follow you (tm still is a mystery to me). I
don't remember the history of the flag, but our internal version has a
T_WAS_CANCELED flag at almost the same spot which is set on any matched
CANCEL and is only used for a t_was_canceled() function and we didn't
have any problem with it.  Only without it ;)

> You could use also t_grep_status("487"), if any branch did receive a
> 487, it will return true.

Oh, that is would it does. I was wondering about it just yesterday.

Regards,
Martin