[Serdev] LDAP module contributed - CALL for opinions!!

[Greger V. Teigre]

Hi Rogelio,
Thanks a lot for that patch! There have been many people looking for 
ldap modules, some have starting implement, and some have actually 
implemented, but not contributed :-)
http://www.iptel.org/ldap_and_ldap_authentication_modules

ldap is on the things we would like to get into ser as a module, and I 
would like others with plans/code to come forward now!!  Also, those 
with an interest/stake in ldap, please review and provide your opinions.

Just to clarify your intentions, Rogelio: Is this a one-time 
contribution, or are you interested in further developing/extend ldap 
support over time as a SER module in the main code respoitory?

I did a quick review (without compiling), and to me it looks like a 
simple implementation that does it job.  The only thing I notices is 
that you have reused www_authorize etc functions. If you look at the 
auth_radius module, you will see that these should be prefixed to avoid 
confusion with the "standard" db-based functions (due to lack of name 
spaces :-).

Also, have you looked at the ETH modules 
(http://www.iptel.org/eth_world_module)? I assume this is another 
implementation. Maybe you would like to explain the difference under 
introduction to your modules.

Have you any thoughts on how to implement avpairs for ldap or do you 
just use the mysql database for that?

Finally, I would to point out that you don't have to release the 
copyright to FOKUS Fraunhofer. The standard GPL headers are for code 
copyrighted by FOKUS Fraunhofer. For patches to *existing* files 
copyright by FOKUS, you have to release the copyright, but separate 
files and modules can be copyrighted by you (or other authors of code 
you may have built on).  See 
http://www.iptel.org/ser/development/copyright_policies

g-)

Rogelio Baucells wrote:
> Hi,
>
> I have contributed two modules to the SER project. The first one is a  
> generic LDAP module that handles the connection to the LDAP server and 
> the second one is an authentication module using LDAP as a back end. 
> The authentication module is based on the "authdb_mod", so it contains 
> the same features.
>
> I have tested them in a test environment and it seems to work fine, 
> further testing is required to make it production ready.
>
> Thanks for a great software,
>
> Rogelio J. Baucells
> ------------------------------------------------------------------------
>
> _______________________________________________
> Serdev mailing list
> Serdev at lists.iptel.org
> http://lists.iptel.org/mailman/listinfo/serdev
>   
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.iptel.org/pipermail/serdev/attachments/20070123/a720717a/attachment.html