[Serdev] [Tracker] Closed: (SER-194) Unsafe has function in PA

[Vaclav Kubart (JIRA)]

     [ http://tracker.iptel.org/browse/SER-194?page=all ]

Vaclav Kubart closed SER-194.
-----------------------------

    Resolution: Fixed

Hash function is safer now, but its performance is still very bad - it will be replaced by something better as soon as this part of PA code will be rewritten (in memory data will be cache only - not primary storage like now, cache size will be configurable, ...)

> Unsafe has function in PA
> -------------------------
>
>                 Key: SER-194
>                 URL: http://tracker.iptel.org/browse/SER-194
>             Project: SER
>          Issue Type: Bug
>          Components: Presence
>    Affects Versions: Ottendorf
>            Reporter: Andrei Pelinescu - Onciul
>         Assigned To: Vaclav Kubart
>             Fix For: Ottendorf
>
>
> Hi,
> Jiri found an unsafe hash function in pa (modules/pa/pdomain.c:37).
> This is the same old usrloc hash, but in an worse version: it returns
> an int and the result is used as a hashtable index => could be negative.
>  (return res % _d->size and res can become negative => the remainder in
>  C can be negative).
> It's ok if I replace it in the same way as for usrloc? (another hash
> func, fixed hash table size)
> Andrei

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tracker.iptel.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira