[Serdev] CVS:commitlog: sip_router/modules/gflags gflags.c

[Andrei Pelinescu-Onciul]

On Dec 10, 2006 at 22:14, Michal Matyska <michal at iptel.org> wrote:
> Andrei,
> 
> what do you think about the idea to shortly reopen the SER-189 and
> change the code in modules/gflags/gflags.c to this:
> 
> static void mod_destroy(void)
> {
> 	if (avps_1 != 0) {
> 		destroy_avp_list(&avps_1);
> 	}
> 	if (avps_2 != 0) {
> 		destroy_avp_list(&avps_2);
> 	}
> 	active_global_avps = 0;
> }
> 
> 
> 
> I feel this way it is much more readable and understandable.


Yes, it looks better to me too. So from my point of view go ahead an
make the change, but note that I'm not the module maintainer :-)
The module was written by Jiri. I think Jan added the avp stuff and
later Vladimir (vlada) made some changes too (reload global attrs
a.s.o). 


Andrei