[Serdev] Path module commit in CVS

Cesc cesc.santa at gmail.com
Fri Jun 17 12:43:14 UTC 2005


The TLS stuff is thought to be checked out and then copied into
SERROT/tls ... there are too many files which include
tls/tls_somefile.h headers that it would be a mess ... i think.
Anyway, this process needs not be done very often ... TLS is stable :)

In my opinion, find a way to make it as simple as possible for the
user to use this "experimental" code ... it is "bad" enough to have
them on a separate tree. Let me know if i need to change something

Cesc

> >>>> + Should I adapt the path to point to the right place, from CVS
> >>>> path point of view? I mean, instead of the above using something
> >>>> like:
> >>>>
> >>>> #include "../../sip_router/sr_module.h"
> >>>> #include "../../sip_router/parser/msg_parser.h"
> >>>
> >>> Yes, I think we should aim at having experimental modules compiled
> >>> where they are and assuming that the experimental and sip_router
> >>> trees are at the same level. In fact, I think this should be
> >>> described in the experimental README file. I'm collecting content
> >>> :-)
> >>
> >> Maybe a flexible approach is to use a conditional directive,
> >> something like that:
> >>
> >> #ifdef _EXPERIMENTAL_CVS
> >> #include "../../sip_router/sr_module.h"
> >> #include "../../sip_router/parser/msg_parser.h"
> >> #else
> >> #include "../../sr_module.h"
> >> #include "../../parser/msg_parser.h"
> >> #endif
> >>
> >> Therefore, in the Makefile in the experimental branch, the
> >> _EXPERIMENTAL_CVS directive would be use (as -D switch in the gcc
> >> command). And, if the code needs to be tested in the module/
> >> conventional SER directory, just not using the directive will lead
> >> to compile against the right .h ubications.
> >>
> >> This procedure (or a variation) could be use in all the experimental
> >> modules. What's your opinion?
> >
> >  In my opinion it should be possible to put all the stuff from
> >  experimental module directly into the sip_router tree and compile
> >  there. This is how I think most people will use it, they will check
> >  out the sip_router directory and then they will check out the
> >  contents of the experimental directory into it.
> 
> Cesc has done exactly that for the TLS module, but he chose ./tls from the
> root (I assume he has his own stuff compiled there).
> I agree with you. The general instructions could be "move the experimental
> tree into the sip_router directory and look in each README of experimental
> modules for any dependencies on libraries/other software, as well as core
> patching required.  Then add each module you want to compile to the make
> command... HOW?"
> 
> >  We would propbably need some changes in the Makefiles of SER because
> >  they only assume that modules reside in modules directory (this would
> >  be not true in this case as some of them will be in experimental
> >  subdir). Andrei is the best person to anwer this.
> 
> What would be the best solution? Obviously, due to patching and
> dependencies, we want people to *explicitly* specify each module in the
> experimental dir they want to compile.  Could we add something like make
> include_exp_module="path tls" ?
> g-)
> 
>




More information about the Serdev mailing list