[Serdev] CVS:commitlog: sip_router/modules/nathelper nathelper.c

Jiri Kuthan jiri at iptel.org
Sat Aug 21 14:47:47 UTC 2004


Hi Maxim,

may I suggest you use sip_msg->msg_flags as opposed to sip_msg->flags
... flags are used by scripts (i.e., require script writer's flag usage
convention) whereas msg_flags are for internal use (i.e., require
SER programmers' flag usage convention).

msg_flags bits occupied today are defined in parser/msg_parser.h:

#define FL_FORCE_RPORT 1 /* force rport */
#define FL_FORCE_ACTIVE 2 /* force active SDP */
 

Thanks,

-jiri

At 02:51 PM 8/20/2004, Maxim Sobolev wrote:
>sobomax     2004/08/20 14:51:10 CEST
>
>  SER CVS Repository
>
>  Modified files:
>    modules/nathelper    nathelper.c 
>  Log:
>  Put simple anti-foot-shooting measure against attempts to rewirite
>  the same SDP several times - mark all processed messages with flags (250
>  for those with altered IP and 251 with altered port) and check if one
>  of those is set when another request for rewrite comes. Otherwise,
>  SDP will most likely to be broken as a result.
>  
>  Revision  Changes    Path
>  1.54      +33 -1     sip_router/modules/nathelper/nathelper.c
>http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/sip_router/modules/nathelper/nathelper.c.diff?r1=1.53&r2=1.54
>
>_______________________________________________
>Serdev mailing list
>serdev at lists.iptel.org
>http://lists.iptel.org/mailman/listinfo/serdev

--
Jiri Kuthan            http://iptel.org/~jiri/ 




More information about the Serdev mailing list