[Serdev] minor postgres patches

[Greg Fausak]

Sure, I'll get this added today.

However, I'm concerned about 'not building properly'.
The code should build, and report a problem at run time.
This should not keep the code from building (as far as I know).

---greg

> -----Original Message-----
> From: serdev-bounces at lists.iptel.org 
> [mailto:serdev-bounces at lists.iptel.org] On Behalf Of Jan Janak
> Sent: Friday, July 25, 2003 4:33 AM
> To: Alexander Mayrhofer
> Cc: serdev at lists.iptel.org
> Subject: Re: [Serdev] minor postgres patches
> 
> 
> Hello,
> 
> I agree, Greg, could you, please integrate the path into BOTH, stable
> and unstable branch ?
> 
> I think that in this case it will be faster to do the changes by hand
> because they are very easy. Just add MODULE_VERSION to 
> db_mod.c and add
> -I/usr/include/postgres into the Makefile.
> 
>   regards, Jan.
> 
> On 25-07 10:02, Alexander Mayrhofer wrote:
> > 
> > Hi,
> > 
> > SER's postgres module does not build properly in yesterday's CVS. I
> > suggest two minor patches to fix that:
> > 
> > - adding MODULE_VERSION
> > 
> > ---snip---
> > 
> > --- modules/postgres/db_mod.c.orig      Fri Jul 25 09:49:58 2003
> > +++ modules/postgres/db_mod.c   Fri Jul 25 09:50:30 2003
> > @@ -37,6 +37,7 @@
> >  #include "../../sr_module.h"
> >  #include "dbase.h"
> > 
> > +MODULE_VERSION
> > 
> >  static int mod_init(void);
> > 
> > ---snip---
> > 
> > - adding "debian-friendly" includes
> > 
> > ---snip---
> > 
> > --- modules/postgres/Makefile.orig      Fri Jul 25 09:49:44 2003
> > +++ modules/postgres/Makefile   Fri Jul 25 09:54:50 2003
> > @@ -7,7 +7,7 @@
> >  NAME=postgres.so
> > 
> >  # libpq-fe.h locations
> > -DEFS +=-I/usr/local/pgsql/include
> > +DEFS +=-I/usr/local/pgsql/include -I/usr/include/postgresql
> >  LIBS=-L$(LOCALBASE)/pgsql/lib -L$(LOCALBASE)/lib/pgsql 
> -L/usr/pkg/lib \
> >                 -L/usr/pkg/lib/pgsql -lpq
> > 
> > ---snip---
> > 
> > There are some architecture-dependent #define's in the 
> module's sources, e.g. 
> > Linux seems only to be supported on x86. I've successfully 
> tried the module on 
> > Linux/powerpc (after changing __x86 to __powerpc in 
> aug_sysdep.h), so i 
> > wonder if that dependency is neccessary at all? Some 
> endianess problems i did 
> > miss?
> > 
> > thanks
> > 
> > Alex Mayrhofer
> > nic.at
> > 
> > _______________________________________________
> > Serdev mailing list
> > serdev at lists.iptel.org
> > http://lists.iptel.org/mailman/listinfo/serdev
> 
> _______________________________________________
> Serdev mailing list
> serdev at lists.iptel.org
> http://lists.iptel.org/mailman/listinfo/serdev
>