[Kamailio-Devel] [ openser-Patches-2687309 ] new modparam("tm", "relay_reason_100", "Trying")

[SourceForge.net]

Patches item #2687309, was opened at 2009-03-15 02:13
Message generated for change (Comment added) made by henningw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2687309&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Andreas Heise (aheise)
Assigned to: Nobody/Anonymous (nobody)
Summary: new modparam("tm", "relay_reason_100", "Trying")

Initial Comment:

Hello,

attached is a patch against trunk version for a new modparam("tm", "relay_reason_100", "Trying") which
allow to modify the value without recompileing

following text should be added to the documentation:

1.3.21. relay_reason_100 (string)

   Define the text reason for the 100 reply generated
   by the TM module after receiving an INVITE request.

   Default value is "Giving a Try".

   Example 1.21. Set relay_reason_100 parameter
...
modparam("tm", "relay_reason_100", "Trying")
...

regards,
Andreas

----------------------------------------------------------------------

>Comment By: Henning Westerholt (henningw)
Date: 2009-03-16 10:38

Message:
Hi Andreas,

there are some small issues with the patch. You need to give the char * to
the modparam statement and not the str. And then you need to update the
length in the mod_init function of the module. Take a look at other modules
that uses str parameters for an example. This should also fix the problem
you observed.

Henning

----------------------------------------------------------------------

Comment By: Andreas Heise (aheise)
Date: 2009-03-15 02:52

Message:
after some testing I found an issue with the patch, the default value
"Giving a Try" is a string of 12 chars, but if the string is defined by the
modparam e.g. "Trying" then the string has still 12 chars, the len is not
updated that means the the string is truncated or filled by other values
and may be a risk of memory leak?. I don't found the cause for this issue
and hope an core developer can help to fix this issue.

many thanks,
Andreas

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2687309&group_id=139143